Update classes for custom typography #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In Gutenberg 7.9, how some classes were applied in the editor has changed, which has broken some of the custom typography.
This PR fixes that in the parent theme's custom typography code. If there are issues in the child themes, I'll address them in seperate PRs.
This PR also includes a fix for fonts on the front end for the categories, archives and file blocks.
Lastly, there's some pretty gnarly issues with the button block as of 7.9 that I'll be addressing separately; only that block's custom typography in the editor needs to be checked with this PR.
See #893.
How to test the changes in this Pull Request:
In my examples, the titles should be using Impact, and the body should be using Chalkboard -- specific blocks I noticed issues with, include:
Post/Page title:
Before - using the theme default:
After:
Header Blocks
Before - using the body font:
After:
Table block:
Before - using theme's default body font:
After:
Button Block:
Before - using body font:
After:
Homepage Posts block:
Before - entry meta using theme's default:
After:
Subtitle (on single post):
Before - using theme's default body font:
After:
Other information: